hqx871 commented on PR #64167: URL: https://github.com/apache/doris/pull/64167#issuecomment-4903399614
> Review questions / rollout concerns: > > 1. Should this feature have an FE config-level rollout flag or kill switch? Tenant-level colocate introduces new persistent metadata/edit logs and checker/balancer behavior, so it would be useful to disable new create/alter usage, and ideally planner/repair behavior, while still being able to read existing metadata. > 2. What is the intended behavior with the existing `colocate_with` property? The PR description says the new `colocate_group` and the old `colocate_with` are independent and can be used together, but the current create/alter code rejects mixed usage. Either the coexistence semantics need to be implemented and tested, or the PR description/docs/error messages should state that they are mutually exclusive. > 3. Should the current limitations be exposed in user-facing docs or errors? The PR mentions restore is not supported, Cloud mode is not supported, and partition/load balance has limitations when only some tenant tags use colocate. These constraints should be visible to users if they remain. 2. `can be used together` means different tables can use the two feature independently, not for the same table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
