heguanhui commented on code in PR #63864:
URL: https://github.com/apache/doris/pull/63864#discussion_r3540093827
##########
regression-test/suites/query_p0/ddl/show_trash/test_nereids_trash.groovy:
##########
@@ -20,6 +20,32 @@ suite("show_trash_nereids") {
checkNereidsExecute("""show trash;""")
checkNereidsExecute("""show trash on "127.0.0.1:9050";""")
Review Comment:
Regarding the parser bug you identified (the ON clause being silently
ignored and falling back to all backends), I completely agree. This parser bug
has actually been fundamentally fixed in the related PR
[#63860](https://github.com/apache/doris/pull/63860). That PR addresses:
The missing return statement in LogicalPlanBuilder.visitShowTrash() that
caused the ON clause to be ignored.
The syntax inconsistency between SHOW TRASH ON and ADMIN CLEAN TRASH ON, now
supporting multiple backends with parenthesized comma-separated list, e.g.,
SHOW TRASH ON ("be1:9050", "be2:9050").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
