github-actions[bot] commented on code in PR #65351:
URL: https://github.com/apache/doris/pull/65351#discussion_r3541693868
##########
regression-test/suites/external_table_p0/iceberg/test_iceberg_deletion_vector.groovy:
##########
@@ -328,6 +328,49 @@ class IcebergRestCatalog {
qt_q3 """ SELECT * FROM dv_test_orc ORDER BY id; """
qt_no_delete """ SELECT * FROM dv_test_no_delete ORDER BY id; """
+ def enableFileScannerV2Rows = sql """SHOW VARIABLES LIKE
'enable_file_scanner_v2'"""
+ assertTrue(enableFileScannerV2Rows.size() > 0,
+ "Session variable enable_file_scanner_v2 is not found")
+ String originalEnableFileScannerV2 =
enableFileScannerV2Rows[0][1].toString()
+ try {
+ sql """set enable_file_scanner_v2=false"""
+ GetDebugPoint().clearDebugPointsForAllBEs()
+ GetDebugPoint().enableDebugPointForAllBEs(
+ "IcebergDeleteFileReader.read_deletion_vector.io_error")
+ test {
+ sql """ SELECT count(*) FROM dv_test; """
+ exception "injected Iceberg deletion vector read failure"
+ }
+
+ GetDebugPoint().clearDebugPointsForAllBEs()
+ GetDebugPoint().enableDebugPointForAllBEs(
+ "IcebergDeleteFileReader.read_deletion_vector.should_stop")
+ test {
+ sql """ SELECT count(*) FROM dv_test; """
+ exception "stop read"
Review Comment:
This V1 `should_stop` case will not produce the expected exception. With
`enable_file_scanner_v2=false`, the debug point makes
`read_iceberg_deletion_vector` return `Status::EndOfFile("stop read.")` during
reader initialization, but V1 `FileScanner::_get_next_reader` treats any
init-time `END_OF_FILE` as an empty file and continues to the next split. When
the splits are exhausted it returns OK with scanner EOF, so this regression can
pass only if some other path fails; it is not testing the intended
cancellation/read-stop path. Please make this V1 fault inject a non-EOF error,
or cover the `io_ctx.should_stop` behavior in a BE unit test where
`END_OF_FILE` is asserted directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
