github-actions[bot] commented on code in PR #65353:
URL: https://github.com/apache/doris/pull/65353#discussion_r3543041140
##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/ProfileManager.java:
##########
@@ -979,8 +997,8 @@ public void markExecutionProfileFinished(TUniqueId queryId)
{
try {
ExecutionProfile execProfile =
queryIdToExecutionProfiles.get(queryId);
if (execProfile == null) {
- LOG.debug("Profile {} does not exist, already finished or does
not enable profile",
- DebugUtil.printId(queryId));
+ LOG.warn("Execution profile {} does not exist when marking
query finished, {}",
Review Comment:
This is another expected auto-profile cleanup path that now logs at WARN.
For a query that finishes under `auto_profile_threshold_ms`,
`StmtExecutor.finalizeQuery()` calls `updateProfile(true)`,
`Profile.updateSummary(..., true)` removes the profile through
`ProfileManager.removeProfile()`, and then `finalizeQuery()` immediately calls
`QeProcessorImpl.unregisterQuery()`, which still reaches
`markExecutionProfileFinished()`. At that point `execProfile == null` is
intentional, so this warning will fire during normal FE unregister even before
any final BE profile report is involved. Please keep the known
removed/disabled-profile case at DEBUG, or only warn when the state proves the
profile was not intentionally filtered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
