github-actions[bot] commented on code in PR #65292:
URL: https://github.com/apache/doris/pull/65292#discussion_r3543373902
##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/action/ProfileAction.groovy:
##########
@@ -26,6 +26,12 @@ import org.apache.doris.regression.util.JdbcUtils
@Slf4j
class ProfileAction implements SuiteAction {
+ private static final long DEFAULT_PROFILE_WAIT_TIMEOUT_MS = 30000
Review Comment:
This default shortens the wait budget for two of the converted tests.
`scanner_profile` now calls `getProfileBySql(pattern, requiredContents)`
without passing a timeout, and `s3_load_profile_test` calls `waitProfile(...,
"Load profile ${jobId}")` without one, so both inherit this 30s default. Before
this PR those exact waits used `Awaitility.await().atMost(60, SECONDS)` while
waiting for asynchronously reported BE profile counters, and the new
`profile_waiting_time_for_spill_seconds = 60` only delays FE profile storage;
it does not make the Groovy polling loop wait longer. Under CI load these
suites can now fail after 30s even though the old code would have kept polling.
Please preserve the previous 60s budget either here or at the converted call
sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
