github-actions[bot] commented on code in PR #65391:
URL: https://github.com/apache/doris/pull/65391#discussion_r3544141417
##########
regression-test/suites/inverted_index_p2/test_show_data.groovy:
##########
@@ -813,7 +833,8 @@ suite("test_show_data_with_compaction", "p2") {
assertTrue(another_with_index_size != "wait_timeout")
logger.info("with_index_size is {}, another_with_index_size is {}",
with_index_size, another_with_index_size)
- assertEquals(another_with_index_size, with_index_size)
Review Comment:
This still needs to compare the two config paths. The old assertion checked
that the table compacted with `inverted_index_compaction_enable=true` reported
the same `SHOW DATA` size as the table compacted with the config disabled.
After this change, each value is only checked against an independent range, so
a regression like 170 KB vs 200 KB in non-cloud mode, or 55 KB vs 70 KB in
cloud mode, would pass even though the two implementations disagree materially.
Please keep the absolute sanity range if it is needed for cloud/non-cloud
variance, but also compare `with_index_size` and `another_with_index_size` with
a relative tolerance, for example by reusing `assert_show_data_size_close` for
the documents table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
