Yukang-Lian commented on code in PR #15339:
URL: https://github.com/apache/doris/pull/15339#discussion_r1064168397


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/FunctionSet.java:
##########
@@ -2609,14 +2634,33 @@ private void initAggregateBuiltins() {
                             .createBuiltin("topn_weighted", 
Lists.newArrayList(t, Type.BIGINT, Type.INT, Type.INT),
                                     new ArrayType(t), t,
                                     "", "", "", "", "", true, false, true, 
true));
+
             addBuiltin(AggregateFunction.createBuiltin(HIST, 
Lists.newArrayList(t), Type.VARCHAR, t,
                     "", "", "", "", "", true, false, true, true));
+
             addBuiltin(AggregateFunction.createBuiltin(HISTOGRAM, 
Lists.newArrayList(t), Type.VARCHAR, t,
                     "", "", "", "", "", true, false, true, true));
+
             addBuiltin(AggregateFunction.createBuiltin(HIST, 
Lists.newArrayList(t, Type.DOUBLE, Type.INT), Type.VARCHAR, t,
                                     "", "", "", "", "", true, false, true, 
true));
-            addBuiltin(AggregateFunction.createBuiltin(HISTOGRAM, 
Lists.newArrayList(t, Type.DOUBLE, Type.INT), Type.VARCHAR, t,
+
+            addBuiltin(AggregateFunction.createBuiltin(HISTOGRAM, 
Lists.newArrayList(t, Type.DOUBLE, Type.INT),
+                    Type.VARCHAR, t,
+                    "", "", "", "", "", true, false, true, true));
+
+            addBuiltin(AggregateFunction.createBuiltin(HISTOGRAM, 
Lists.newArrayList(t, Type.DOUBLE, Type.INT),
+                    Type.VARCHAR, t,
                     "", "", "", "", "", true, false, true, true));
+
+
+            addBuiltin(AggregateFunction.createBuiltin(GROUP_UNIQ_ARRAY, 
Lists.newArrayList(t), new ArrayType(t), t,
+                    "", "", "", "", "", true, false, true, true));
+
+            addBuiltin(AggregateFunction.createBuiltin(GROUP_UNIQ_ARRAY, 
Lists.newArrayList(t), new ArrayType(t), t,
+                    "", "", "", "", "", true, false, true, true));
+            addBuiltin(
+                    AggregateFunction.createBuiltin(GROUP_UNIQ_ARRAY, 
Lists.newArrayList(t, Type.INT), new ArrayType(t),
+                            t, "", "", "", "", "", true, false, true, true));

Review Comment:
   keep this part and cancel other changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to