HappenLee commented on code in PR #15674:
URL: https://github.com/apache/doris/pull/15674#discussion_r1064308852
##########
be/src/vec/functions/function_string.h:
##########
@@ -1940,22 +1940,20 @@ class FunctionMoneyFormat : public IFunction {
ColumnPtr argument_column = block.get_by_position(arguments[0]).column;
auto result_column = assert_cast<ColumnString*>(res_column.get());
- auto data_column = assert_cast<const typename
Impl::ColumnType*>(argument_column.get());
Review Comment:
I think the origin way is better? why change the logic, maybe `template
MoneyFormatDecimalImpl ` is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
