github-actions[bot] commented on code in PR #65325:
URL: https://github.com/apache/doris/pull/65325#discussion_r3549876037
##########
fe/fe-common/src/main/java/org/apache/doris/job/cdc/DataSourceConfigKeys.java:
##########
@@ -39,6 +39,7 @@ public class DataSourceConfigKeys {
public static final String SNAPSHOT_PARALLELISM = "snapshot_parallelism";
public static final String SNAPSHOT_PARALLELISM_DEFAULT = "1";
public static final String SKIP_SNAPSHOT_BACKFILL =
"skip_snapshot_backfill";
+ public static final String SCHEMA_CHANGE_ENABLED = "schema_change_enabled";
Review Comment:
This adds `schema_change_enabled` as a source config key and the
MySQL/Postgres readers honor it via `includeSchemaChanges(...)`, but the
from-to job path cannot actually pass it through. `CREATE JOB` and `ALTER JOB`
source properties are validated by `DataSourceConfigValidator.validateSource()`
before the CDC request is built, and `ALLOW_SOURCE_KEYS` does not include this
new key, so `"schema_change_enabled" = "false"` is rejected as `Unexpected
key`. If this is intended to be a user-facing escape hatch, please whitelist it
and validate it as a boolean, with FE validation coverage; otherwise the
disable-path tests should be kept internal to the TVF payload flag so they do
not imply that from-to jobs can disable schema changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
