morrySnow commented on code in PR #65393:
URL: https://github.com/apache/doris/pull/65393#discussion_r3550179230


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/PartitionIncrementMaintainer.java:
##########
@@ -444,6 +451,20 @@ public Void visitLogicalWindow(LogicalWindow<? extends 
Plan> window, PartitionIn
             return super.visitLogicalWindow(window, context);
         }
 
+        @Override
+        public Void visitLogicalPartitionTopN(LogicalPartitionTopN<? extends 
Plan> partitionTopN,
+                PartitionIncrementCheckContext context) {
+            if (!planOutputContainsPartitionColumnToCheck(partitionTopN, 
context)) {
+                return super.visitLogicalPartitionTopN(partitionTopN, context);

Review Comment:
   The error message says "window partition sets" but this method handles 
LogicalPartitionTopN, not a window. Consider changing to "PartitionTopN 
partition keys does not contain the target partition" to avoid misleading debug 
output.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to