github-actions[bot] commented on code in PR #65365:
URL: https://github.com/apache/doris/pull/65365#discussion_r3550613140
##########
fe/be-java-extensions/paimon-scanner/src/main/java/org/apache/doris/paimon/PaimonJniScanner.java:
##########
@@ -571,4 +590,12 @@ private static String[] splitParam(String value, String
delimiter) {
return value.split(delimiter);
}
+ private Map<String, String> buildTableOptions(Map<String, String>
tableOptions) {
+ Map<String, String> options = new HashMap<>(tableOptions);
+ options.put(CoreOptions.READ_BATCH_SIZE.key(),
String.valueOf(batchSize));
+ if
(Boolean.parseBoolean(params.getOrDefault(DORIS_ENABLE_FILE_READER_ASYNC,
"true")) == false) {
Review Comment:
This adds a new user-visible catalog option, but the PR does not add a test
that exercises the option path. `PaimonScanNode` now forwards
`paimon.jni.enable_file_reader_async` as scan-level
`jni.enable_file_reader_async`, and the BE JNI adapter prefixes that back to
`paimon.jni.enable_file_reader_async` before this branch disables async by
overriding `file-reader-async-threshold`. The only new unit test covers
iterator release, so a key/prefix drift here would silently leave async reading
enabled. Please add focused coverage for the new knob, e.g. an FE test that
`paimon.jni.enable_file_reader_async=false` reaches `paimon_options`, plus a
scanner-side test that the false value sets
`CoreOptions.FILE_READER_ASYNC_THRESHOLD` to the max threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
