github-actions[bot] commented on code in PR #15718:
URL: https://github.com/apache/doris/pull/15718#discussion_r1064429007
##########
be/src/exec/schema_scanner/schema_tables_scanner.h:
##########
@@ -29,13 +31,14 @@ class SchemaTablesScanner : public SchemaScanner {
virtual Status start(RuntimeState* state);
Review Comment:
warning: 'start' overrides a member function but is not marked 'override'
[clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status start(RuntimeState* state);
^
```
**be/src/exec/schema_scanner.h:84:** overridden virtual function is here
```cpp
virtual Status start(RuntimeState* state);
^
```
##########
be/src/exec/schema_scanner/schema_tables_scanner.h:
##########
@@ -29,13 +31,14 @@
virtual Status start(RuntimeState* state);
virtual Status get_next_row(Tuple* tuple, MemPool* pool, bool* eos);
Review Comment:
warning: 'get_next_row' overrides a member function but is not marked
'override' [clang-diagnostic-inconsistent-missing-override]
```cpp
virtual Status get_next_row(Tuple* tuple, MemPool* pool, bool* eos);
^
```
**be/src/exec/schema_scanner.h:85:** overridden virtual function is here
```cpp
virtual Status get_next_row(Tuple* tuple, MemPool* pool, bool* eos);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
