github-actions[bot] commented on code in PR #65379:
URL: https://github.com/apache/doris/pull/65379#discussion_r3557090196
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/S3Resource.java:
##########
@@ -232,6 +229,11 @@ public void modifyProperties(Map<String, String>
properties) throws DdlException
}
// compatible with old version, Need convert if modified properties
map uses old properties.
S3Properties.convertToStdProperties(properties);
+ if (properties.containsKey(S3Properties.ENDPOINT)) {
+ String endpoint =
S3Util.buildEndpointUrl(properties.get(S3Properties.ENDPOINT));
Review Comment:
`buildEndpointUrl` also runs for empty updates after
`convertToStdProperties`, so `ALTER RESOURCE ... SET ("AWS_ENDPOINT" = "")` (or
`"s3.endpoint" = ""`) is no longer ignored by the existing
`replaceIfEffectiveValue` guard. `buildEndpointUrl("")` returns the non-empty
string `https://`, and with `s3_validity_check=false` this gets written to both
endpoint keys, leaving the resource with an invalid endpoint instead of
preserving the old value. Please skip blank endpoint values before
normalization, or validate/reject them before they can be persisted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
