github-actions[bot] commented on code in PR #65480:
URL: https://github.com/apache/doris/pull/65480#discussion_r3564235245
##########
regression-test/suites/external_table_p0/hive/test_hive_orc_predicate.groovy:
##########
@@ -45,8 +58,66 @@ suite("test_hive_orc_predicate", "p0,external") {
qt_predicate_null_aware_equal_in_rt """select * from table_a inner
join table_b on table_a.age <=> table_b.age and table_b.id in (1,3) order by
table_a.id;"""
Review Comment:
This still does not prove that ScannerV2 initialized an ORC SearchArgument.
The suite forces `enable_file_scanner_v2`, and ordinary Hive ORC ranges are
eligible for V2, but the guard you rely on here is enforced only by the legacy
`be/src/format/orc/vorc_reader.cpp` path. In the V2 path,
`be/src/format_v2/orc/orc_reader.cpp::_init_search_argument_from_local_filters()`
just returns OK when `has_pushdown` is false and never checks
`check_orc_init_sargs_success`. These assertions can therefore pass via normal
row filtering even if the V2 SARG/min-max pruning path was not initialized.
Please either make the V2 ORC reader honor this session variable, or assert
V2-specific profile evidence such as `UseScannerV2=true` plus
SearchArgument/stripe-pruning activity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
