github-actions[bot] commented on code in PR #65560:
URL: https://github.com/apache/doris/pull/65560#discussion_r3575728527
##########
be/src/format_v2/table_reader.h:
##########
@@ -909,6 +939,10 @@ class TableReader {
FileAggregateResult file_result;
const auto status =
_data_reader.reader->get_aggregate_result(file_request, &file_result);
if (status.is<ErrorCode::NOT_IMPLEMENTED_ERROR>()) {
+ if (_push_down_agg_type == TPushAggOp::type::COUNT_NON_NULL) {
Review Comment:
This makes an optional pushdown miss fail the query. `Status::NotSupported`
is `NOT_IMPLEMENTED_ERROR`, and the Parquet/ORC aggregate readers still return
it for cases they cannot answer from metadata or levels, such as unsupported
Parquet nested layouts or missing ORC stripe/column statistics. The per-split
mapper can also reject the target when a TVF glob contains a later file where
the column is missing/defaulted; the normal scan path can synthesize those
values. Since the scan still has the real count column projected,
`COUNT_NON_NULL` needs the same fallback behavior as COUNT/MINMAX: leave
`pushed_down=false` and scan rows normally instead of returning an error for
valid `count(col)` queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
