github-actions[bot] commented on code in PR #65129:
URL: https://github.com/apache/doris/pull/65129#discussion_r3578297447
##########
fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java:
##########
@@ -223,7 +223,15 @@ public Pair<PlanNode, LocalExchangeType>
enforceAndDeriveLocalExchange(PlanTrans
: LocalExchangeType.NOOP;
} else {
// Intersect / Except
- if (AddLocalExchange.isColocated(this)) {
+ if (AddLocalExchange.isColocated(this) || isBucketShuffle()) {
Review Comment:
Please add a targeted local-exchange test for this new `isBucketShuffle()`
leg. The existing `testSetOperationAndAssertNumRowsNode()` still covers a
partitioned `IntersectNode` and a colocated `ExceptNode`, and the new helper
test only exercises `RequireSpecific.autoRequireHash()`. If this `||
isBucketShuffle()` branch were dropped, those unit tests would still pass. A
small `IntersectNode` or `ExceptNode` with
`setDistributionMode(BUCKET_SHUFFLE)` and NOOP/tracking children should assert
`BUCKET_HASH_SHUFFLE` output and bucket-hash child requirements directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
