shuke987 commented on code in PR #65543:
URL: https://github.com/apache/doris/pull/65543#discussion_r3585516465
##########
regression-test/suites/show_p0/test_show_create_table_and_views_nereids.groovy:
##########
@@ -99,7 +115,7 @@ suite("test_show_create_table_and_views_nereids", "show") {
(2, 200, 1111),
(23, 900, 1)"""
- qt_show "SHOW CREATE TABLE ${dbName}.${tableName}"
+ quickRunTest("show_initial_replica_${effectiveReplicaNum}", "SHOW CREATE
TABLE ${dbName}.${tableName}")
Review Comment:
Thanks for checking the cloud path. Cloud P0 does select this suite, and
cloud `SHOW CREATE TABLE` would emit `file_cache_ttl_seconds`. However, cloud
FE startup currently forces `enable_feature_binlog=false` in
`DorisFE.overwriteConfigs()` because binlog is unsupported in cloud mode. This
suite checks that config and returns before the first `quickRunTest`, so these
replica-specific golden blocks are unreachable in Cloud P0. The pre-check
before that guard only verifies hidden-column behavior and does not compare the
table property list.
If cloud binlog support is enabled in the future, the enabling change should
add and validate cloud-specific complete SHOW CREATE golden blocks. Adding
guessed cloud goldens now would leave them unexecutable and unvalidated.
Therefore no code change is needed for the current execution path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
