morrySnow commented on code in PR #65659:
URL: https://github.com/apache/doris/pull/65659#discussion_r3588041180
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalTable.java:
##########
@@ -444,7 +444,10 @@ public SelectedPartitions
initSelectedPartitions(Optional<MvccSnapshot> snapshot
return SelectedPartitions.NOT_PRUNED;
}
Map<String, PartitionItem> nameToPartitionItems =
getNameToPartitionItems(snapshot);
- return new SelectedPartitions(nameToPartitionItems.size(),
nameToPartitionItems, false);
+ Optional<SortedPartitionRanges<String>> sortedPartitionRanges =
Optional.ofNullable(
+ SortedPartitionRanges.build(nameToPartitionItems));
+ return new SelectedPartitions(nameToPartitionItems.size(),
nameToPartitionItems, false, false,
+ sortedPartitionRanges);
Review Comment:
should find a way to use cached sort partitions, should not build it just in
time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
