Gabriel39 commented on code in PR #65674:
URL: https://github.com/apache/doris/pull/65674#discussion_r3592304981
##########
be/src/format_v2/parquet/reader/scalar_column_reader.cpp:
##########
@@ -142,33 +145,32 @@ Status ScalarColumnReader::read(int64_t rows,
MutableColumnPtr& column, int64_t*
return Status::InternalError("Parquet record reader is not initialized
for column {}",
_name);
}
- auto reader = leaf_reader();
- ParquetLeafBatch leaf_batch;
- RETURN_IF_ERROR(reader.read_batch(rows, &leaf_batch, rows_read));
+ auto& reader = leaf_reader();
+ RETURN_IF_ERROR(reader.read_batch(rows, &_leaf_batch, rows_read));
Review Comment:
Fixed in 913123e6cfe. ParquetLeafBatch now releases Arrow binary/dictionary
chunk ownership immediately after synchronous Doris materialization on normal,
dictionary-filter, nested, levels-only, and error paths. Borrowed StringRef
scratch is also cleared before the owning chunks are released, while vector
capacity remains reusable. Added ownership/capacity and success/error-path UT
coverage; remote ASAN BE build, clang-format check, and 16 focused UTs pass.
The separate v2 complex-column temporary materialization/OOM redesign is not
being hidden behind this lifecycle fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
