github-actions[bot] commented on code in PR #65709:
URL: https://github.com/apache/doris/pull/65709#discussion_r3594603721
##########
fe/fe-connector/fe-connector-jdbc/src/main/java/org/apache/doris/connector/jdbc/client/JdbcClickHouseConnectorClient.java:
##########
@@ -133,7 +133,7 @@ protected String getCatalogName(Connection conn) throws
SQLException {
@Override
protected String[] getTableTypes() {
- return new String[] {"TABLE", "VIEW", "SYSTEM TABLE"};
+ return new String[] {"TABLE", "VIEW", "SYSTEM TABLE", "REMOTE TABLE"};
Review Comment:
[P1] Preserve materialized-view discovery on JDBC V2
ClickHouse JDBC V2 0.9.8 classifies engine `MaterializedView` as
`MATERIALIZED VIEW`, and its `getTables()` engine filter only includes the
requested type strings. Because this allowlist still omits that type, a V2
catalog drops materialized views from both listing and existence checks, even
though V1 returned the same engine as the already-allowed `VIEW`; selecting one
therefore fails before column lookup. Please add `MATERIALIZED VIEW` to both
ClickHouse client allowlists and cover it in the V2 regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
