github-actions[bot] commented on code in PR #65708:
URL: https://github.com/apache/doris/pull/65708#discussion_r3594620085
##########
fe/fe-core/src/test/java/org/apache/doris/datasource/PluginDrivenExternalTableEngineTest.java:
##########
@@ -99,6 +99,17 @@ public void testTableTypeIsAlwaysPluginExternalTable() {
"Internal table type should always be PLUGIN_EXTERNAL_TABLE");
}
+ @Test
+ public void testGsonPostProcessRestoresMissingRemoteName() throws
Exception {
+ PluginDrivenExternalTable table = createTableWithCatalogType("jdbc");
+ table.setRemoteName(null);
+
+ table.gsonPostProcess();
Review Comment:
This directly manufactures a null field and invokes `gsonPostProcess()`, but
the current FE durable startup paths do not deserialize an `ExternalTable`:
`CatalogMgr` persists only catalogs, the old serialized `idToDb`/`idToTbl`
caches are gone, legacy init-catalog/init-db replay is ignored, and
`ExternalTable.read()` has no caller. Live tables are instead rebuilt through
`buildTableForInit`, which supplies the remote name. As a result this test can
pass while the advertised old-image/restart path never executes the new
assignment. Please reproduce this from an actual supported image/journal entry
and put the fallback on that live path; if no such persisted artifact exists,
this callback change is a no-op for the stated bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
