morningman opened a new pull request, #65740: URL: https://github.com/apache/doris/pull/65740
## What Delete six unreferenced classes under `fe/fe-core/.../datasource/` that were orphaned by the catalog-SPI migration, plus one dead test: - **`DatabaseMetadata`** / **`TableMetadata`** — interfaces superseded by fe-connector-api's `ConnectorDatabaseMetadata`; their fe-core implementors (`HiveDatabaseMetadata`, `HiveTableMetadata`) were already removed in earlier migration PRs. - **`DorisTypeVisitor`** — iceberg type-tree visitor with no subclasses or call sites. - **`ExternalUtil`** (+ **`ExternalUtilTest`**) — Column/Type → thrift-schema helper whose only callers were the now-deleted legacy `IcebergScanNode` / `PaimonScanNode`. - **`FileSplitStrategy`** — never-wired split-assignment stub (TODO from #31047). - **`EmptyMvccSnapshot`** — unused `MvccSnapshot` implementation; the interface stays alive via `ConnectorMvccSnapshotAdapter` / `PluginDrivenMvccSnapshot`. Net: **7 files, 702 deletions**, no additions. ## Why Dead-code cleanup on the catalog-SPI migration. Each class was verified to have **zero production references** anywhere in `fe/` — no imports, implementors, reflection / `Class.forName`, GSON / editlog registration, `ServiceLoader`, or catalog-type-string routing. The only residual mentions are prose javadoc/comments in the iceberg/paimon connectors and plan-docs, which are non-code. ## How verified `fe-core` `test-compile` passes (main + test sources compile cleanly after the deletions). Part of #65185. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01AkwFY4c7kZkLKZeazy3UMW -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
