github-actions[bot] commented on code in PR #65749:
URL: https://github.com/apache/doris/pull/65749#discussion_r3600633973
##########
cloud/script/run_all_tests.sh:
##########
@@ -157,9 +164,15 @@ for i in *_test; do
continue
fi
- LLVM_PROFILE_FILE="./report/${i}.profraw" "./${i}"
--gtest_print_time=true --gtest_output="xml:${i}.xml" "${filter}"
- last_ret=$?
+ test_log=$(mktemp)
+ LLVM_PROFILE_FILE="./report/${i}.profraw" "./${i}"
--gtest_print_time=true --gtest_output="xml:${i}.xml" "${filter}" 2>&1 | tee
"${test_log}"
+ last_ret=${PIPESTATUS[0]}
echo "${i} ret=${last_ret}"
Review Comment:
This branch can make the runner pass without proving that the selected
gtests completed and passed. A real `[ FAILED ]` result followed by the
documented exit-time FDB crash still has its nonzero status reset here;
moreover, `Transaction::init()` calls `fdb_transaction_set_option` during
active tests, so even that exact signature can occur before the current case or
remaining cases complete. The two whole-log greps can also pair a Doris-owned
ASAN report with an unrelated `libfdb_c.so` mention. Please waive only after
the fresh `${i}.xml` proves all selected tests completed with zero
failures/errors and the ASAN report matches the narrow known fault frame; keep
missing/incomplete XML or any other sanitizer report nonzero, and add runner
tests for these mixed cases.
##########
cloud/script/run_all_tests.sh:
##########
@@ -157,9 +164,15 @@ for i in *_test; do
continue
fi
- LLVM_PROFILE_FILE="./report/${i}.profraw" "./${i}"
--gtest_print_time=true --gtest_output="xml:${i}.xml" "${filter}"
- last_ret=$?
+ test_log=$(mktemp)
+ LLVM_PROFILE_FILE="./report/${i}.profraw" "./${i}"
--gtest_print_time=true --gtest_output="xml:${i}.xml" "${filter}" 2>&1 | tee
"${test_log}"
+ last_ret=${PIPESTATUS[0]}
echo "${i} ret=${last_ret}"
+ if [[ ${last_ret} -ne 0 ]] && is_fdb_asan_failure "${test_log}"; then
Review Comment:
This branch can make the runner pass without proving that the selected
gtests completed and passed. A real `[ FAILED ]` result followed by the
documented exit-time FDB crash still has its nonzero status reset here;
moreover, `Transaction::init()` calls `fdb_transaction_set_option` during
active tests, so even that exact signature can occur before the current case or
remaining cases complete. The two whole-log greps can also pair a Doris-owned
ASAN report with an unrelated `libfdb_c.so` mention. Please waive only after
the fresh `${i}.xml` proves all selected tests completed with zero
failures/errors and the ASAN report matches the narrow known fault frame; keep
missing/incomplete XML or any other sanitizer report nonzero, and add runner
tests for these mixed cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
