wenzhenghu commented on PR #65126: URL: https://github.com/apache/doris/pull/65126#issuecomment-4999586705
While addressing the two HMS event-related correctness findings raised during the review of this PR, we performed a broader audit of the HMS incremental event processing paths, including database/table create, drop and rename events, table refresh/insert events, and partition add/drop/alter events. That audit identified four additional correctness gaps that are already present on the current `master` baseline and were not introduced by this PR: 1. ALTER TABLE/ALTER DATABASE rename may be incorrectly cancelled because the so-called local existence check can load through to HMS. 2. ADD/DROP PARTITION events do not fence an in-flight partition-values load, and DROP may skip partition/file cache invalidation when the partition-values entry is cold. 3. Incremental CREATE_DATABASE/CREATE_TABLE events can bypass `include_database_list`, `exclude_database_list`, or `include_table_list` visibility filters. 4. DROP_PARTITION records a database deletion instead of a partition deletion in `ExternalMetaIdMgr`. These baseline issues are now tracked separately in #65750, with code references, reproduction scenarios, and suggested fixes. Keeping them in a dedicated issue allows the current PR to remain focused on the HMS event regressions found during its review while ensuring the broader findings are not lost and can be fixed in follow-up PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
