morrySnow commented on code in PR #65644:
URL: https://github.com/apache/doris/pull/65644#discussion_r3604602730
##########
fe/fe-extension-loader/src/test/java/org/apache/doris/extension/loader/testplugins/BadNameTestPluginFactory.java:
##########
@@ -15,13 +15,24 @@
// specific language governing permissions and limitations
// under the License.
-package org.apache.doris.catalog.stream;
+package org.apache.doris.extension.loader.testplugins;
+
+import org.apache.doris.extension.spi.Plugin;
+import org.apache.doris.extension.spi.PluginFactory;
/**
- * Read mode of a stream scan after binding.
+ * Test factory whose self-reported name violates the load-time charset rule.
*/
-public enum StreamReadMode {
- INCREMENTAL,
- SNAPSHOT,
- RESET
+public class BadNameTestPluginFactory implements PluginFactory {
Review Comment:
文件夹的名字和文件名字都要符合规范
##########
fe/fe-extension-loader/src/main/java/org/apache/doris/extension/loader/PluginHandle.java:
##########
@@ -37,16 +37,26 @@ public final class PluginHandle<F extends PluginFactory> {
private final ClassLoader classLoader;
private final F factory;
private final Instant loadedAt;
+ private final String description;
+ private final String implementationVersion;
Review Comment:
为什么不是 version，而是 implementationVersion？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
