Gabriel39 commented on code in PR #65784:
URL: https://github.com/apache/doris/pull/65784#discussion_r3610091306
##########
be/src/format/table/table_schema_change_helper.cpp:
##########
@@ -73,6 +73,9 @@ bool find_file_field_idx_by_name_mapping(
return true;
}
}
+ // An explicit empty or unmatched Iceberg mapping means the legacy
field is absent;
+ // falling back to its current name would bind an unrelated physical
column.
+ return false;
Review Comment:
Addressed by 54ab787b88a and extended in adfe227951e. Mixed schemas use
Iceberg's existential any-ID rule and retain authoritative field-ID matches
recursively.
##########
be/src/format_v2/column_mapper.cpp:
##########
@@ -82,12 +82,16 @@ bool column_has_name(const ColumnDefinition& column, const
std::string& name) {
}
bool column_names_match(const ColumnDefinition& lhs, const ColumnDefinition&
rhs) {
- if (column_has_name(rhs, lhs.name)) {
- return true;
- }
- if (lhs.has_identifier_name() && column_has_name(rhs,
lhs.get_identifier_name())) {
- return true;
+ if (!lhs.has_name_mapping) {
Review Comment:
Addressed by 54ab787b88a. The authoritative flag is only emitted by
compatible FE plans, while older plans retain the legacy current-name fallback
during rolling upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
