Gabriel39 commented on code in PR #65784:
URL: https://github.com/apache/doris/pull/65784#discussion_r3611966467
##########
be/src/format_v2/table/iceberg_position_delete_sys_table_reader.cpp:
##########
@@ -132,24 +133,14 @@ void set_iceberg_delete_field_id(ColumnDefinition*
column) {
}
}
-bool has_field_id(const std::vector<ColumnDefinition>& schema) {
- for (const auto& field : schema) {
- if (!field.has_identifier_field_id()) {
- return false;
- }
- if (!has_field_id(field.children)) {
- return false;
- }
- }
- return true;
-}
-
class PositionDeleteFileTableReader final : public format::TableReader {
protected:
format::TableColumnMappingMode mapping_mode() const override {
- return !_data_reader.file_schema.empty() &&
has_field_id(_data_reader.file_schema)
- ? format::TableColumnMappingMode::BY_FIELD_ID
- : format::TableColumnMappingMode::BY_NAME;
+ if (!_data_reader.file_schema.empty() &&
+ schema_has_any_field_id(_data_reader.file_schema)) {
Review Comment:
Fixed in c4f800c8511. The V2 Parquet position-delete reader now enables the
same ID-less complex-wrapper projection fallback as ordinary Iceberg scans.
Added a nested-wrapper regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
