github-actions[bot] commented on code in PR #65674:
URL: https://github.com/apache/doris/pull/65674#discussion_r3612102421
##########
be/src/format_v2/orc/orc_file_input_stream.cpp:
##########
@@ -54,8 +55,10 @@ class OrcMergedRangeFileReader final : public io::FileReader
{
_size(_file_reader->size()) {
_statistics.apply_bytes += _range.end_offset - _range.start_offset;
if (_profile != nullptr) {
- const char* profile_name = "MergedSmallIO";
- ADD_TIMER_WITH_LEVEL(_profile, profile_name, 1);
+ const char* profile_name = "OrcMergedSmallIO";
Review Comment:
[P2] Isolate the ORC merged-I/O child counters
Renaming this parent does not isolate the subtree because `RuntimeProfile`
keys counters globally, while `MergeRangeFileReader` still registers
`CopyTime`, `ReadTime`, `RequestIO`, `MergedIO`, `RequestBytes`, and
`MergedBytes` below `MergedSmallIO`. If one scanner profile initializes both
reader kinds, whichever runs first owns those shared children and both readers
update it, leaving the other parent empty or misattributed. This is separate
from the ORC pruning-counter thread: it affects the merged-I/O wrapper and a
different metric family. Please give these ORC children unique names (or
intentionally retain one common parent) and cover both initialization orders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
