github-actions[bot] commented on code in PR #65796:
URL: https://github.com/apache/doris/pull/65796#discussion_r3612786686
##########
be/src/common/config.cpp:
##########
@@ -722,7 +722,7 @@ DEFINE_Int32(fragment_mgr_async_work_pool_queue_size,
"4096");
// The read size is the size of the reads sent to os.
// There is a trade off of latency and throughout, trying to keep disks busy
but
-// not introduce seeks. The literature seems to agree that with 8 MB reads,
random
+// not introduce seeks. The literature seems to agree that with 8 MB reads,
random
Review Comment:
Please drop this unrelated source-comment whitespace change and make
`be_changes` include `.github/workflows/be-ut-mac.yml` instead. Right now this
no-op BE edit is the only reason the final-head job runs; once it is removed,
future workflow-only fixes will again skip the job they change. Selecting the
workflow's own path keeps the patch focused and makes these CI changes
self-testing.
##########
.github/workflows/be-ut-mac.yml:
##########
@@ -96,5 +97,21 @@ jobs:
tar -xvf doris-thirdparty-prebuilt-darwin-x86_64.tar.xz
popd
- export JAVA_HOME="${JAVA_HOME_17_X64%\/}"
+ # macos-15 runners are Apple Silicon (arm64), so the JDK env var is
Review Comment:
`macos-15` is arm64 here, but this job still downloads
`doris-thirdparty-prebuilt-darwin-x86_64.tar.xz` at lines 91-95. The selected
bundle contains x86_64 library objects while `run-be-ut.sh` produces native
arm64 objects; Rosetta can run x86 generators but cannot link those objects
into arm64 tests. Please derive the Darwin archive filename from normalized
`uname -m` for both URL branches while preserving the current release-tag
selection, then rerun through final link and tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
