cyriltovena commented on code in PR #65433:
URL: https://github.com/apache/doris/pull/65433#discussion_r3615260615
##########
be/src/cloud/cloud_storage_engine.cpp:
##########
@@ -133,7 +133,12 @@ struct VaultCreateFSVisitor {
<< " check_fs: " << check_fs;
auto fs = DORIS_TRY(io::S3FileSystem::create(s3_conf, id));
- if (check_fs && !s3_conf.client_conf.role_arn.empty()) {
+ // Probe connectivity for keyless credential modes (assumed role or
+ // GCP Workload Identity): a misconfigured identity should fail loudly
at startup
+ // rather than on the first tablet write.
+ if (check_fs &&
Review Comment:
Thank you for catching this. Fixed in f1274c521c: the state now starts
unsynced and the first successful non-empty vault sync claims the probe with an
atomic exchange. The probe also runs on the refresh path if another concurrent
sync already installed the filesystem.
CloudStorageEngineTest.CheckStorageVaultOnlyOnFirstSync covers the state
transition with enable_check_storage_vault=true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
