github-actions[bot] commented on code in PR #65776:
URL: https://github.com/apache/doris/pull/65776#discussion_r3627167016
##########
gensrc/thrift/BackendService.thrift:
##########
@@ -143,6 +143,9 @@ struct TDiskTrashInfo {
struct TCheckStorageFormatResult {
1: optional list<i64> v1_tablets;
2: optional list<i64> v2_tablets;
+ 3: optional list<i64> inverted_index_v1_tablets;
+ 4: optional list<i64> inverted_index_v2_tablets;
Review Comment:
[Performance] Please avoid doubling the full tablet-ID RPC payload for
summary mode. Every producer now puts each tablet ID once in a legacy
base-format list and again in a new inverted-format list, but this no-argument
RPC is called before the FE branches on verbose, and the non-verbose path uses
only the five list sizes. A summary for N tablets therefore still allocates,
serializes, transfers, and deserializes 2N IDs just to print counts,
potentially hitting the Thrift message limit on large backends. Please add a
count-oriented mode/response or a compact representation that preserves
rolling-upgrade compatibility, with scale coverage.
##########
gensrc/thrift/BackendService.thrift:
##########
@@ -143,6 +143,9 @@ struct TDiskTrashInfo {
struct TCheckStorageFormatResult {
1: optional list<i64> v1_tablets;
2: optional list<i64> v2_tablets;
+ 3: optional list<i64> inverted_index_v1_tablets;
Review Comment:
[Performance] Please avoid doubling the full tablet-ID RPC payload for
summary mode. Every producer now puts each tablet ID once in a legacy
base-format list and again in a new inverted-format list, but this no-argument
RPC is called before the FE branches on verbose, and the non-verbose path uses
only the five list sizes. A summary for N tablets therefore still allocates,
serializes, transfers, and deserializes 2N IDs just to print counts,
potentially hitting the Thrift message limit on large backends. Please add a
count-oriented mode/response or a compact representation that preserves
rolling-upgrade compatibility, with scale coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
