github-actions[bot] commented on code in PR #65664:
URL: https://github.com/apache/doris/pull/65664#discussion_r3628344976
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/MapAgg.java:
##########
@@ -53,7 +53,7 @@ public MapAgg(Expression arg0, Expression arg1) {
/**
* constructor with 2 arguments.
*/
- private MapAgg(boolean distinct, Expression arg0, Expression arg1) {
+ public MapAgg(boolean distinct, Expression arg0, Expression arg1) {
Review Comment:
[P2] Add DISTINCT coverage for the v1 registration
This makes the boolean constructor discoverable by the binder, but every
added `map_agg(DISTINCT ...)` case binds `MapAggV2`:
`BuiltinAggregateFunctions` registers this class only as `map_agg_v1`, while
`map_agg` aliases V2. A failure in the newly enabled `map_agg_v1(DISTINCT ...)`
path would therefore leave this suite green. Please add scalar/grouped
assertions using `map_agg_v1` (and a two-group case if it is intended to
participate in CTE splitting).
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/CollectSet.java:
##########
@@ -108,4 +108,9 @@ public List<FunctionSignature> getSignatures() {
public Expression resultForEmptyInput() {
return new ArrayLiteral(new ArrayList<>(), this.getDataType());
}
+
+ @Override
+ public List<Expression> getDistinctArguments() {
Review Comment:
[P2] Preserve the DISTINCT flag before relying on this override
`collect_set(DISTINCT ...)` never reaches this true branch: both public
boolean constructors delegate to constructors that call `super` without
`distinct`, so `isDistinct()` is false when the selector calls
`getDistinctArguments()`. Consequently the new `two_collect_set` cases do not
exercise CTE splitting; they pass because BE deduplicates `collect_set` by
function name. Either retain the flag and assert the split plan, or remove this
dead override and do not count those cases as split coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
