Gabriel39 commented on code in PR #65965:
URL: https://github.com/apache/doris/pull/65965#discussion_r3639542115
##########
be/benchmark/parquet/AGENTS.md:
##########
@@ -42,7 +42,7 @@ be/output/lib/benchmark_test --benchmark_list_tests \
| grep -c '^ParquetDecoder/' # currently 152
be/output/lib/benchmark_test --benchmark_list_tests \
- | grep -c '^ParquetReader/' # currently 137
+ | grep -c '^ParquetReader/' # currently 138
Review Comment:
Fixed in 8eb8cdb0d88. Updated both reader-count references to 152 and added
ReaderMatrixHasExactUniqueRegistrationNames, using the same shared
reader_scenario_name() function as benchmark registration so count/name drift
is detected. The scenario suite passes under ASAN.
##########
be/benchmark/parquet/benchmark_parquet_reader.hpp:
##########
@@ -275,6 +322,22 @@ inline VExprContextSPtr make_predicate(int
column_position, int selectivity_perc
return context;
}
+inline VExprContextSPtr make_complex_residual_predicate(int
selectivity_percent) {
+ TExprNode node;
+ node.__set_node_type(TExprNodeType::COMPOUND_PRED);
+ node.__set_opcode(TExprOpcode::COMPOUND_AND);
+ node.__set_type(std::make_shared<DataTypeUInt8>()->to_thrift());
+ node.__set_num_children(2);
+ node.__set_is_nullable(false);
+ auto compound = VCompoundPred::create_shared(node);
+ compound->add_child(std::make_shared<Int32PairSumLessThanExpr>(0, 1, 2 *
selectivity_percent));
Review Comment:
Fixed in 8eb8cdb0d88. Replaced the custom pair-sum leaf with prepared/opened
production VectorizedFnCall nodes: c0 < selectivity_percent followed by the
genuinely reachable multi-column c2 = c3 child. The scan tests now use the same
production expression shape and assert
ReaderReadRows/ReaderSelectRows/ReaderSkipRows. The benchmark header compiles
with the Release benchmark flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
