wenzhenghu commented on code in PR #65126:
URL: https://github.com/apache/doris/pull/65126#discussion_r3655722463
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/RefreshManager.java:
##########
@@ -172,45 +172,65 @@ public void replayRefreshTable(ExternalObjectLog log) {
LOG.warn("failed to find db when replaying refresh table: {}",
log.debugForRefreshTable());
return;
}
- Optional<? extends ExternalTable> table;
- if (!Strings.isNullOrEmpty(log.getTableName())) {
- table = db.get().getTableForReplay(log.getTableName());
+ String localTableName;
Review Comment:
Fixed in `74941ba59fb`.
For name-bearing database and table refresh logs, replay now falls back to
invalidating the independent engine caches directly with the canonical local
`dbName` / `tableName` retained in the edit log when the database object cache
has no current value, including when it is disabled by TTL 0. This path remains
cache-only and does not load or warm the database object cache.
I added dedicated TTL-0 replay coverage for both database and table
refreshes with an enabled recording engine cache. The tests also assert that
the database object loader is never invoked. `RefreshManagerTest` passes all 6
tests, FE checkstyle reports 0 violations, and `git diff --check` passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
