github-actions[bot] commented on code in PR #65609:
URL: https://github.com/apache/doris/pull/65609#discussion_r3664677158
##########
regression-test/suites/variant_p0/load.groovy:
##########
@@ -107,22 +108,24 @@ suite("regression_test_variant", "p0"){
// 2. type confilct cases
def table_name = "type_conflict_resolution"
- create_table table_name
- sql """insert into ${table_name} values (1, '{"c" : "123"}');"""
- sql """insert into ${table_name} values (2, '{"c" : 123}');"""
- sql """insert into ${table_name} values (3, '{"cc" : [123.2]}');"""
- sql """insert into ${table_name} values (4, '{"cc" : [123.1]}');"""
- sql """insert into ${table_name} values (5, '{"ccc" : 123}');"""
- sql """insert into ${table_name} values (6, '{"ccc" : 123321}');"""
- sql """insert into ${table_name} values (7, '{"cccc" : 123.22}');"""
- sql """insert into ${table_name} values (8, '{"cccc" : 123.11}');"""
- sql """insert into ${table_name} values (9, '{"ccccc" : [123]}');"""
- sql """insert into ${table_name} values (10, '{"ccccc" :
[123456789]}');"""
- sql """insert into ${table_name} values (11, '{"b" :
1111111111111111}');"""
- sql """insert into ${table_name} values (12, '{"b" : 1.222222}');"""
- sql """insert into ${table_name} values (13, '{"bb" : 1}');"""
- sql """insert into ${table_name} values (14, '{"bb" :
214748364711}');"""
- sql """insert into ${table_name} values (15, '{"A" : 1}');"""
Review Comment:
This makes the Variant numeric-conflict case deterministic by collapsing it
to one tablet and one rowset with compaction disabled, but it also removes the
storage topology that can create the conflict. The new
`NumericConflictResolvedAsJsonbPreservesOriginalNumberText` test explicitly
cites different tablets yet only parses two rows into one in-memory
`ColumnVariant`; it never writes, merges, reads, or compacts rowsets. Please
retain this stable case and add deterministic cross-rowset/cross-tablet
coverage with explicitly waited compaction so number-text behavior remains
covered end to end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
