eldenmoon commented on code in PR #65561:
URL: https://github.com/apache/doris/pull/65561#discussion_r3664698600
##########
be/src/exprs/function/function_variant_element.cpp:
##########
@@ -97,10 +100,72 @@ class FunctionVariantElement : public IFunction {
return make_nullable(col);
}
+ // Keep legacy/V2 physical-column dispatch in one entry point so nullable
handling stays shared.
+ // NOLINTNEXTLINE(readability-function-size)
Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
uint32_t result, size_t input_rows_count) const
override {
- const auto* variant_col = check_and_get_column<ColumnVariant>(
-
remove_nullable(block.get_by_position(arguments[0]).column).get());
+ const ColumnPtr materialized =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const IColumn* physical = materialized.get();
+ std::span<const uint8_t> outer_nulls;
+ if (const auto* nullable =
check_and_get_column<ColumnNullable>(physical)) {
+ outer_nulls = nullable->get_null_map_data();
+ physical = &nullable->get_nested_column();
+ }
+ if (const auto* variant_v2 =
check_and_get_column<ColumnVariantV2>(physical)) {
+ if (block.empty()) {
+ block.replace_by_position(result,
ColumnNullable::create(ColumnVariantV2::create(),
+
ColumnUInt8::create()));
+ return Status::OK();
+ }
+
+ auto replace_with_all_null_result = [&]() {
+ auto null_values = ColumnVariantV2::create();
+ null_values->insert_many_defaults(variant_v2->size());
+ block.replace_by_position(
+ result, ColumnNullable::create(std::move(null_values),
+
ColumnUInt8::create(variant_v2->size(), 1)));
+ };
+ const auto& index_argument = block.get_by_position(arguments[1]);
+ const ColumnPtr materialized_index =
+ index_argument.column->convert_to_full_column_if_const();
+ const IColumn* index_column = materialized_index.get();
+ if (index_column->is_null_at(0)) {
+ replace_with_all_null_result();
+ return Status::OK();
+ }
+ if (const auto* nullable =
check_and_get_column<ColumnNullable>(*index_column)) {
+ index_column = &nullable->get_nested_column();
+ }
+
+ std::optional<VariantElementV2PathSegment> segment;
+ const PrimitiveType index_type =
+ remove_nullable(index_argument.type)->get_primitive_type();
+ if (is_string_type(index_type)) {
+ segment =
VariantElementV2PathSegment::object_key(index_column->get_data_at(0));
Review Comment:
will be solved in Next steps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
