eldenmoon opened a new pull request, #66196:
URL: https://github.com/apache/doris/pull/66196
### What problem does this PR solve?
Issue Number: None
Related PR: #63088
Problem Summary:
Array elements are nullable after #63088. `get_base_type_of_array()`
therefore returns `Nullable<Variant>` for the NestedGroup physical type, but
`is_nested_group_type()` directly casts that wrapper to `DataTypeVariant`. The
false negative bypasses the NestedGroup-specific type-conflict policy during
Variant merge/compaction.
This PR unwraps the nullable base type only when the input has an Array
dimension. It recognizes `Array<Nullable<Variant>>` as NestedGroup while
preserving the existing classifications of scalar `Variant` and
`Nullable<Variant>`.
### Release note
None
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test
- `GLIBC_COMPATIBILITY=OFF ./run-be-ut.sh --run
--filter=ColumnVariantNestedGroupTypeTest.nullable_array_element_is_recognized`
- `GLIBC_COMPATIBILITY=OFF ./run-be-ut.sh --run
--filter='ColumnVariantTest.*'` (91 tests passed)
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [ ] No.
- [x] Yes. Arrays whose innermost element is `Nullable<Variant>` are now
recognized as NestedGroup and use its intended conflict-resolution policy.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
