JNSimba commented on code in PR #681:
URL:
https://github.com/apache/doris-flink-connector/pull/681#discussion_r3670627856
##########
flink-doris-connector/flink-doris-connector-base/src/main/java/org/apache/doris/flink/sink/writer/DorisWriteMetrics.java:
##########
@@ -187,8 +192,10 @@ public void register(SinkWriterMetricGroup
sinkMetricGroup) {
private void flushSuccessLoad(RespContent responseContent) {
Optional.ofNullable(responseContent.getLoadBytes()).ifPresent(totalFlushLoadBytes::inc);
+
Optional.ofNullable(responseContent.getLoadBytes()).ifPresent(numBytesSend::inc);
Optional.ofNullable(responseContent.getNumberLoadedRows())
.ifPresent(totalFlushLoadedRows::inc);
+
Optional.ofNullable(responseContent.getNumberLoadedRows()).ifPresent(numRecordsSend::inc);
Review Comment:
These two standard metrics should represent the number of records sent from
Flink to Doris, rather than the number of records actually written to Doris,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
