sollhui commented on code in PR #66105:
URL: https://github.com/apache/doris/pull/66105#discussion_r3689206499
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java:
##########
@@ -1353,6 +1353,16 @@ public void afterAborted(TransactionState txnState,
boolean txnOperated, String
}
// TODO(ml): use previous be id depend on change reason
}
+ if (txnStatusChangeReason !=
TransactionState.TxnStatusChangeReason.NO_PARTITIONS) {
Review Comment:
Addressed in 324aa532e97. The aborted task attachment diagnostics are now
copied through a dedicated helper before the job enters PAUSED, without
updating aborted progress or renewing the task. The paused-abort unit test
again verifies both errorLogUrl and firstErrorMsg.
##########
regression-test/suites/load_p0/routine_load/test_routine_load_be_restart.groovy:
##########
@@ -73,18 +73,19 @@ suite("test_routine_load_be_restart","nonConcurrent") {
RoutineLoadTestUtils.sendTestDataToKafka(producer,
kafkaCsvTopics)
GetDebugPoint().enableDebugPointForAllFEs(injection_abort_txn)
RoutineLoadTestUtils.waitForTaskAbort(runSql, job, 60)
+ def pausedJob = sql "show routine load for ${job}"
+ assertEquals("PAUSED", pausedJob[0][8].toString())
+
assertTrue(pausedJob[0][17].toString().contains("TASKS_ABORT_ERR"))
Review Comment:
Addressed in 324aa532e97. The regression assertions now match
ErrorReason.toString(): errCode = 103 for CREATE_TASKS_ERR and errCode = 104
for TASKS_ABORT_ERR, while still checking the concrete MEM_LIMIT_EXCEEDED,
TOO_MANY_TASKS, and coordinator-restart messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
