sollhui commented on code in PR #66105:
URL: https://github.com/apache/doris/pull/66105#discussion_r3701095191
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java:
##########
@@ -1353,6 +1353,15 @@ public void afterAborted(TransactionState txnState,
boolean txnOperated, String
}
// TODO(ml): use previous be id depend on change reason
}
+ if (txnStatusChangeReason !=
TransactionState.TxnStatusChangeReason.NO_PARTITIONS) {
+ String msg = "be " + taskBeId + " abort task,"
+ + " task id: " + routineLoadTaskInfo.getId()
+ + " job id: " + routineLoadTaskInfo.getJobId()
+ + " with reason: " + txnStatusChangeReasonString;
+ updateState(JobState.PAUSED,
Review Comment:
Addressed in 5dd9b659044. Generic routine-load task abort pauses are now
derived from the durable ABORTED transaction record: the live callback applies
PAUSED without writing a second routine-load journal entry, and
replayOnAborted() restores the same TASKS_ABORT_ERR transition when the
matching task is still active in a RUNNING job. This makes the truncated replay
prefix recover the pause while keeping stale/removed task aborts from affecting
a newer job generation. The obsolete NO_PARTITIONS exception was removed
because empty/all-unselected loads have committed successfully since #7240.
Added a unit test for the abort-only replay prefix and verified that the live
path does not emit a separate edit-log record. Tests were not run per request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
