morrySnow commented on code in PR #65968:
URL: https://github.com/apache/doris/pull/65968#discussion_r3702040681
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalRepeat.java:
##########
@@ -57,6 +57,7 @@ public class LogicalRepeat<CHILD_TYPE extends Plan> extends
LogicalUnary<CHILD_T
private final List<List<Expression>> groupingSets;
private final List<NamedExpression> outputExpressions;
private final Optional<SlotReference> groupingId;
+ private final Optional<List<Long>> groupingIdValues;
Review Comment:
和groupingSets挨着放吧,这里是不是要保证 groupingSets.size() == groupingIdValues.size()?
如果是的话,需要在构造的时候检查
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]