seawinde commented on code in PR #66287:
URL: https://github.com/apache/doris/pull/66287#discussion_r3702309887
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/stream/TableStreamManager.java:
##########
@@ -314,27 +314,17 @@ public void
fillTableStreamValuesMetadataResult(List<TRow> dataBatch) {
trow.addToColumnValue(new
TCell().setStringVal(stream.getScanTypeString()));
// STREAM_COMMENT
trow.addToColumnValue(new
TCell().setStringVal(stream.getComment()));
+ List<String> baseTableQualifiers =
stream.getBaseTableFullQualifiers();
Review Comment:
Fixed in `6baebd9e78a`. `getBaseTableFullQualifiers()` no longer always
returns the creation-time qualifiers from `baseTableInfo`: when the same-ID
base table is available, it returns the live table qualifiers, so
`table_streams` reflects `ALTER TABLE ... RENAME`; when the table is
recoverably dropped, it resolves the same-ID recycle-bin entry; only if neither
can be resolved does it fall back to the creation-time qualifiers.
`table_streams` also resolves the base table once per row and passes that
snapshot into the qualifier calculation. Unit coverage includes `ALTER TABLE
... RENAME` and `RECOVER TABLE ... AS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
