seawinde commented on code in PR #63899:
URL: https://github.com/apache/doris/pull/63899#discussion_r3711301103
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/PartitionIncrementMaintainer.java:
##########
@@ -172,7 +174,7 @@ public Void visitLogicalUnion(LogicalUnion union,
PartitionIncrementCheckContext
context.collectFailedTableSet(union);
context.addFailReason("not union all output pass partition
increment check");
}
- return super.visit(union, context);
+ return null;
Review Comment:
Thanks, this is a valid gap introduced when the redundant parent traversal
was removed. Fixed in 13a425b69a2 by propagating a fatal state from any UNION
ALL child context to the parent before merging lineage results. I also added a
negative test where a child both reaches a valid partition relation and
contains a LogicalIntersect. Verified with `./run-fe-ut.sh --run
org.apache.doris.nereids.rules.exploration.mv.PartitionColumnTraceTest` (52
tests passed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
