HappenLee commented on code in PR #66366:
URL: https://github.com/apache/doris/pull/66366#discussion_r3721220672


##########
be/src/cloud/cloud_tablet.cpp:
##########
@@ -1540,14 +1540,14 @@ Status CloudTablet::check_delete_bitmap_cache(int64_t 
txn_id,
     Status st = engine.txn_delete_bitmap_cache().get_delete_bitmap(
             txn_id, tablet_id(), &cached_delete_bitmap, nullptr, nullptr);
     if (st.ok()) {
-        bool res = (expected_delete_bitmap->cardinality() == 
cached_delete_bitmap->cardinality());
-        auto msg = fmt::format(
-                "delete bitmap cache check failed, cur_cardinality={}, 
cached_cardinality={}"
-                "txn_id={}, tablet_id={}",
-                expected_delete_bitmap->cardinality(), 
cached_delete_bitmap->cardinality(), txn_id,
-                tablet_id());

Review Comment:
   错误字符串中 cached_cardinality={} 与 txn_id={} 之间缺少逗号或空格,最终会输出成
     cached_cardinality=10txn_id 这个问题顺手修了吧, `然后补一个arrow largetint的nullable的处理用例 
现在ut里面是非null的



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to