yiguolei commented on code in PR #66470:
URL: https://github.com/apache/doris/pull/66470#discussion_r3725568074
##########
be/src/exprs/expr_zonemap_filter.h:
##########
@@ -110,6 +112,19 @@ inline bool field_types_compatible(PrimitiveType lhs,
PrimitiveType rhs) {
return lhs == rhs || (is_string_type(lhs) && is_string_type(rhs));
}
+inline bool field_is_nan(const Field& field, PrimitiveType type) {
Review Comment:
把这个方法直接放到field。h 里吧。
field 里存储了primtive type，单纯的filed 自己就可以判断自己是不是nan了。
所以直接给field 增加一个函数 is_nan 就行了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
