924060929 opened a new pull request, #66530:
URL: https://github.com/apache/doris/pull/66530
## What problem does this PR solve?
Replace string-encoded cache keys with typed key classes that use Java's
equals/hashCode for comparison. All ConnectorExpression implementations already
carry structural equals, so every key field — filter conjuncts, partition
lists, option maps, file scopes — is stored as its natural Java type rather
than an encoded String.
## Changes
- **ConnectorStatementScope SPI**: `computeIfAbsent(String)` →
`computeIfAbsent(Object)`
- **4 connector ScanReuseKey classes**: add `equals`/`hashCode`, use raw
types (`List`, `Map`, `ConnectorExpression`)
- **ConnectorScanKeyUtils**: canonicalize only filter flattening (removed
unused encode/encodeList/stableMapToString)
- **Remove `String.join(",")` aliasing bugs** (4 sites in Hive/Iceberg/Hudi)
- **Deduplicate** `canonicalFilter` and `stableMapToString` helpers
- **Update all** `ConnectorStatementScope` implementations for new signature
- **Fix** `ConnectorStatementScopeImpl` javadoc for re-entrancy contract
## Test
- 247 targeted tests pass (IcebergScanPlanProviderTest,
PaimonScanPlanProviderTest, HudiScanReuseKeyTest, ConnectorStatementScopeTest,
etc.)
- Checkstyle clean
- Compile clean
## Related
Replaces the fe-core ExternalScanTaskCache prototype (branch
fix/cir-21262-iceberg-split-reuse) with the connector-SPI approach on
master-test.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
