morrySnow commented on PR #66565: URL: https://github.com/apache/doris/pull/66565#issuecomment-5213829610
Minor observation: The `MergeIntoCommandTest` now covers both INNER_JOIN (no NOT MATCHED) and RIGHT_OUTER_JOIN (with NOT MATCHED) paths through `MergeUtils.buildMergeJoin`. There is no corresponding test for the external path (`ExternalRowLevelMergePlanBuilder`) exercising the RIGHT_OUTER_JOIN branch. Since both paths share `MergeUtils.buildMergeJoin`, the risk is low, but a test passing a `MergeNotMatchedClause` to the external builder would close the coverage gap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
