maks3201 commented on PR #66563:
URL: https://github.com/apache/doris/pull/66563#issuecomment-5218111088
@JNSimba you're right, thank you for catching this. I re-checked the code
and confirmed `validateAlterOffset()` in JdbcSourceOffsetProvider rejects any
offset that is not JSON so `ALTER JOB ... PROPERTIES('offset'='initial')`
throws before it ever reaches `alterJob()`. The reset code in this PR is
attached to that unreachable path.
I mixed up two different callers from my local branch. The one I upstreamed
here (on ALTER) is dead code on master. The real trigger is internal, it's a
fallback that runs when a streaming task fails with a specific error and the
job needs to re snapshot automatically, that path is reachable and it's where
this reset logic actually belongs.
I'm going to close this PR and move the reset logic into a follow up that
includes the real trigger, so the fix is tied to code that actually executes.
Thanks again for reviewing, sorry for the noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
