bobhan1 opened a new pull request, #66643:
URL: https://github.com/apache/doris/pull/66643
### What problem does this PR solve?
Issue Number: N/A
Related PR: #28546
Problem Summary: Creating HLL value columns in duplicate and unique key
tables is supported, but `ALTER TABLE ADD COLUMN` still rejects them because
`SchemaChangeHandler` retains an obsolete `AGG_KEYS`-only type check. This PR
removes the stale check so schema changes use the existing model-specific
`NONE` or `REPLACE` aggregation behavior and the empty HLL default for
historical rows. After the change, adding and reading HLL columns succeeds for
duplicate, unique merge-on-write, and unique merge-on-read tables.
### Release note
Allow HLL columns to be added to duplicate and unique key tables.
### Check List (For Author)
- Test
- [x] Regression test
- `./run-regression-test.sh --run -d schema_change_p0 -s
test_add_hll_column_non_aggregate_tables`
- `./build.sh --fe -j100`
- `./build.sh --be -j100` with ASAN
- `build-support/check-format.sh`
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
- Behavior changed:
- [ ] No.
- [x] Yes. `ALTER TABLE ADD COLUMN` now accepts HLL value columns in
duplicate and unique key tables.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
