Gabriel39 commented on code in PR #66628:
URL: https://github.com/apache/doris/pull/66628#discussion_r3758742480
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergScanPlanProvider.java:
##########
@@ -2800,13 +2800,13 @@ private Table resolveTable(ConnectorSession session,
IcebergTableHandle handle)
// re-validates the credential even on a scope hit).
IcebergCatalogOps ops = catalogOpsResolver.apply(session);
Table raw = IcebergStatementScope.sharedTable(session,
handle.getDbName(), handle.getTableName(), () -> {
- if (context == null) {
- return loadRawTable(ops, handle);
- }
try {
- return context.executeAuthenticated(() -> loadRawTable(ops,
handle));
+ return context == null
+ ? loadRawTable(ops, handle)
+ : context.executeAuthenticated(() -> loadRawTable(ops,
handle));
} catch (Exception e) {
- throw new RuntimeException("Failed to load table for scan,
error message is:" + e.getMessage(), e);
+ throw IcebergExceptionUtils.wrapTableLoadFailure(
Review Comment:
Fixed for the File Scanner V2 scope in 365bc4390c1. Missing manifest
list/body failures are normalized at ordinary/count/cache-fallback planning,
streaming estimate and lazy split iteration, scan-node equality-delete/property
discovery, and native position_deletes planning. Unrelated runtime failures
remain unchanged, and eager cache failures still reach the SDK fallback first.
Per the requested scope, the serialized JNI system-table route and BE
IcebergSysTableJniScanner (V1) were intentionally left unchanged. Regressions
cover the V2 eager, lazy, property, and native system-table boundaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
